Skip to content

fix: incorrect passing of Thread instance to Store.save_thread #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2025
Merged

fix: incorrect passing of Thread instance to Store.save_thread #9

merged 2 commits into from
Oct 10, 2025
+4 −1

Conversation

quettabit
Copy link
Contributor

@quettabit quettabit commented Oct 7, 2025 •
edited
Loading

as Thread is passed to save_thread and given it already has items field, it leads to the following runtime error on the read path:

TypeError: chatkit.types.Thread() got multiple values for keyword argument 'items'

and it happens at:

chatkit-python/chatkit/server.py

Line 692 in 4656c56

return Thread(**thread_meta.model_dump(), items=thread_items)

@quettabit quettabit marked this pull request as ready for review October 7, 2025 09:25
@quettabit quettabit changed the title fix incorrect passing of Thread instance to Store.save_thread fix: incorrect passing of Thread instance to Store.save_thread Oct 7, 2025
@quettabit
Copy link
Contributor Author

@jiwon-oai @victor-openai just bumping this one!

jiwon-oai
jiwon-oai approved these changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@jiwon-oai jiwon-oai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m - we're still working on getting some processes set up for this repo though, thanks for your patience!

@weedon-openai weedon-openai added this pull request to the merge queue Oct 10, 2025
Merged via the queue into openai:main with commit 8e2d257 Oct 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiwon-oai jiwon-oai jiwon-oai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quettabit @jiwon-oai @weedon-openai